-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how squoosh is loaded in the image integration #6548
Conversation
🦋 Changeset detectedLatest commit: 61b192d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview netlify-image |
|
!preview netlify-image |
|
!preview netlify-image |
|
!preview netlify-image |
|
!preview netlify-image |
|
!preview netlify-image |
|
packages/integrations/image/src/vendor/squoosh/emscripten-utils.ts
Outdated
Show resolved
Hide resolved
return requestPath | ||
}, | ||
// @ts-expect-error | ||
wasmBinary: bytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The emscripten wrapper code accepts this property and it's the way to provide raw bytes, but the TS types do not allow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have this comment in the code comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes
.wasm
files in the image integration and instead creates base64 encoded versions of them. This ensures that they are bundled with the JS source code.Testing
Docs
N/A, bug fix