Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tailwind & Turbolinks integration descriptions more consistent #6419

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

yanthomasdev
Copy link
Member

Changes

This PR changes the package.json description for the Tailwind and Turbolinks integrations to make them more consistent with the Partytown one.

Testing

No code changes!

Docs

It's all docs!
/cc @withastro/maintainers-docs

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 4, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2023

🦋 Changeset detected

Latest commit: 55b7dda

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit after my own heart. 💜

@Jutanium
Copy link
Contributor

Jutanium commented Mar 4, 2023

It's beautiful 🥹

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thank you @Yan-Thomas 💜

We should add a patch changeset to this PR so that these updates also make it to npm.

One thing we could think about looking at https://astro.build/integrations/official/ is making these a bit more descriptive too.

Some examples of other descriptions there:

Use React components within Astro

Faster page navigations by prefetching links when the browser is idle.

I’ve made some suggestions and also suggested adding “Deprecated” to the Turbolinks description. Happy for you to make the final call though!

packages/integrations/tailwind/package.json Outdated Show resolved Hide resolved
packages/integrations/turbolinks/package.json Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@yanthomasdev yanthomasdev marked this pull request as draft March 5, 2023 23:45
@yanthomasdev
Copy link
Member Author

Marking this as a draft so we can discuss more about these descriptions internally before merging.

@yanthomasdev yanthomasdev marked this pull request as ready for review March 9, 2023 21:30
@yanthomasdev
Copy link
Member Author

This should be good now 👍, will add another PR updating other integrations titles.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yan!

@natemoo-re natemoo-re merged commit 0de0877 into main Mar 9, 2023
@natemoo-re natemoo-re deleted the yan/fix-npm-desc branch March 9, 2023 22:55
@astrobot-houston astrobot-houston mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants