Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): correctly change configuration when node adapter is added #6333

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Feb 22, 2023

Changes

Fixes #6240

Testing

I tested manually. Unfortunately, I haven't found a way to test these commands.

Screenshot 2023-02-22 at 18 39 52

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023

🦋 Changeset detected

Latest commit: 1a0da2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 22, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great to me! Nice fix.

@ematipico ematipico merged commit 63dda6d into main Feb 22, 2023
@ematipico ematipico deleted the fix/add-node-adapter branch February 22, 2023 20:53
@astrobot-houston astrobot-houston mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node adapter should add mode too
2 participants