Use .mjs extension when building for netlify edge and vercel serverless #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 918a242 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bluwy
commented
Feb 20, 2023
| @@ -30,7 +30,7 @@ | |||
| "build:ci": "astro-scripts build \"src/**/*.ts\"", | |||
| "dev": "astro-scripts dev \"src/**/*.ts\"", | |||
| "test-fn": "mocha --exit --timeout 20000 test/functions/", | |||
| "test-edge": "deno test --allow-run --allow-read --allow-net ./test/edge-functions/", | |||
| "test-edge": "deno test --allow-run --allow-read --allow-net --allow-env ./test/edge-functions/", | |||
There was a problem hiding this comment.
This addition is needed for the test to run, as the adapter executes Deno.env.toObject()
ematipico
approved these changes
Feb 21, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6299
Previously we were using
.jsonly, which might not work if the user doesn't have"type": "module". This adds it and shouldn't break internally when building.This is only required when they use the prerender feature it seems, because it executes
entry.js.Testing
added test in netlify and vercel
Docs
n/a. bug fix.