Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: recursive getCollection() hanging #6257

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Fix: recursive getCollection() hanging #6257

merged 3 commits into from
Feb 16, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

Testing

  • Add layout prop test with recursive getCollection() call

Docs

@bholmesdev bholmesdev marked this pull request as ready for review February 15, 2023 21:53
@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c3bd14e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 15, 2023
bluwy
bluwy approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me! Glad you’re able to find the fix. Looks like we need a changeset too before merging.

@bholmesdev bholmesdev merged commit 2fec478 into main Feb 16, 2023
@bholmesdev bholmesdev deleted the fix/recursive-getcollection-hanging branch February 16, 2023 17:32
@astrobot-houston astrobot-houston mentioned this pull request Feb 16, 2023
Merged
@theurgi theurgi mentioned this pull request Jan 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

astro dev slow or unresponsive when using content collections
3 participants
@bholmesdev @natemoo-re @bluwy