esbuild respects vite.build.minify option
#6222
Conversation
🦋 Changeset detectedLatest commit: 68549ab The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
hi @withastro/maintainers-docs, |
|
Worth to see what the rest of the team thinks of this regarding docs, this is a very specific behavior that I don't think many users will notice, more like a "behind-the-scenes" thing. Though, I can see value in documenting this in the Client-Side-Scripts page, guessing this impacts scripts as well. |
|
Actually this is a debugging option for the cloudflare integration only, without it it is very difficult to get to an error source when running the project no matter if dev or prod. So i was thinking to add a short sentence in the troubleshoot section. |
Sorry, didn't notice it was only for the Cloudflare integration. You're right, adding a small explainer about this in the Troubleshooting section is our best option. You can see the pattern we're using for the Lit integration troubleshooting section as a base for documenting this. Shortly after I can come in and review/approve, thanks! 🙌 |
|
@AirBorne04 are you planning on working on the docs change? |
|
@matthewp yes already have it ready just need to push it, will take care of it next week. |
|
@AirBorne04 ping :) |
|
Just removed Astro Docs Maintainers since Yan is on this one! |
Adding description for debug build
|
@matthewp @Yan-Thomas sorry for the long wait, I was just super busy. I added those two lines of description for the readme. Let me know what you think. |
There was a problem hiding this comment.
No worries @AirBorne04, thanks! I added a few suggestions for you 🙌
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Changes
esbuildrespects thevite.build.minifyoption from astro configTesting
tested with the test projects inside the cloudflare package
Docs
we can add a little info on how to better debug issues during dev
/cc @withastro/maintainers-docs for feedback!