-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate blog and docs starters to content collections #5858
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to Docs, Ben! 💪
I'd punch up that one sentence, but otherwise, no need for this to collect
dust in pulls. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall, but I'd love to see one more pass for code consistency.
For example:
- Some places reference
import * as CONSTS from '../consts'
but then only reference one named export, some places referenceimport { SITE } from '../consts'
. - There are lots of
as Props
littered throughout the code, would be nice to clean this up while we're doing a refactor.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ab37a74
to
363d3cc
Compare
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Changes
with-content
exampleTesting
If it smokes, we're good!
Docs
README updates on blog starter