Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate blog and docs starters to content collections #5858

Merged
merged 17 commits into from
Jan 18, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Migrate blog and docs to content collections
  • Remove with-content example

Testing

If it smokes, we're good!

Docs

README updates on blog starter

@bholmesdev bholmesdev requested a review from a team as a code owner January 13, 2023 22:02
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

⚠️ No Changeset found

Latest commit: a8a1050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 13, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to Docs, Ben! 💪

I'd punch up that one sentence, but otherwise, no need for this to collect dust in pulls. 🚀

examples/blog/README.md Outdated Show resolved Hide resolved
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, but I'd love to see one more pass for code consistency.

For example:

  • Some places reference import * as CONSTS from '../consts' but then only reference one named export, some places reference import { SITE } from '../consts'.
  • There are lots of as Props littered throughout the code, would be nice to clean this up while we're doing a refactor.

examples/docs/src/components/HeadSEO.astro Outdated Show resolved Hide resolved
examples/docs/src/components/PageContent/PageContent.astro Outdated Show resolved Hide resolved
examples/blog/src/layouts/BlogPost.astro Outdated Show resolved Hide resolved
bholmesdev and others added 6 commits January 17, 2023 10:20
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@bholmesdev bholmesdev merged commit 7d72aee into main Jan 18, 2023
@bholmesdev bholmesdev deleted the feat/new-blog-starter branch January 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants