Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content collections] Improve content config handling #5824

Merged
merged 5 commits into from
Jan 11, 2023
Merged

[Content collections] Improve content config handling #5824

merged 5 commits into from
Jan 11, 2023

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jan 10, 2023 •
edited
Loading

Changes

Better handle content type generation failures:

  • Generate types when content directory is empty
  • Log helpful error when running astro sync without a content directory
  • Avoid swallowing config.ts syntax errors from Vite
  • Fix: Generate types when the content/ dir is added in dev

Testing

Manual testing: adding and removing the content directory, adding and modifying the config.ts file.

Docs

withastro/docs#2345

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 96fb348

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 10, 2023
natemoo-re
natemoo-re approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements! LGTM.

@bholmesdev bholmesdev merged commit 665a2c2 into main Jan 11, 2023
@bholmesdev bholmesdev deleted the fix/better-content-config-handling branch January 11, 2023 17:46
@astrobot-houston astrobot-houston mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module 'astro:content'
2 participants
@bholmesdev @natemoo-re