Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MDX Fragment hack #5716

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Remove MDX Fragment hack #5716

merged 3 commits into from
Jan 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 2, 2023

Changes

Removed the hack used by @astrojs/mdx pre v0.12.0. Breaking change for Astro 2.0.

See #5522 for more details.

Testing

Existing test should pass.

Docs

n/a. internal change.

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2023

🦋 Changeset detected

Latest commit: 01d3327

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy bluwy added the semver: major Change triggers a `major` release label Jan 2, 2023
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 2, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks @bluwy. Just one changeset nit.

.changeset/lovely-terms-drive.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@matthewp matthewp merged commit dd56c19 into main Jan 3, 2023
@matthewp matthewp deleted the remove-mdx-fragment branch January 3, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants