Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro/core): Do not automatically add trailing slash #5608

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

konojunya
Copy link
Contributor

@konojunya konojunya commented Dec 14, 2022

Changes

fix #5604

Fixed a problem in which trailing slashes were automatically inserted for URLs set as site key in astro.config.

Testing

Docs

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: a12ec91

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 14, 2022
@bluwy bluwy added the semver: major Change triggers a `major` release label Jan 5, 2023
konojunya and others added 2 commits January 12, 2023 19:21
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @matthewp, I think we still have some time to add this breaking change.

@bluwy bluwy requested a review from matthewp January 16, 2023 07:38
@matthewp
Copy link
Contributor

Yeah I concur, site should be what the user provides that we do not touch, as long as it is a valid URL. But since this is a breaking change I want to bring it up with core first.

@matthewp matthewp merged commit 8992142 into withastro:main Jan 19, 2023
@konojunya konojunya deleted the fix/do-not-auto-add-trailing-slash branch July 30, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically add trailing slash against astroConfig.site
3 participants