Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs example: use HTTPS for site in astro.config.mjs #5603

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Docs example: use HTTPS for site in astro.config.mjs #5603

merged 1 commit into from
Dec 15, 2022

Conversation

arstnei0
Copy link

Changes

Change a little typo

Testing

No tests needed

Docs

No new docs needed

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

⚠️ No Changeset found

Latest commit: bf358e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Dec 14, 2022
delucis
delucis reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any other examples that include the same mistake?

@arstnei0
Copy link
Author

Looks good! Are there any other examples that include the same mistake?

It seems no.

delucis
delucis approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @zihan-ch!

@delucis delucis changed the title Update astro's site url in astro.config.mjs Docs example: use HTTPS for site in astro.config.mjs Dec 15, 2022
@delucis delucis merged commit 7cbe7f5 into withastro:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arstnei0 @delucis