Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide HOST env variable at runtime #5421

Merged
merged 4 commits into from
Nov 17, 2022
Merged

feat: provide HOST env variable at runtime #5421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f169093
feat: provide HOST env variable at runtime
Nov 16, 2022
8ebd595
doc: add change to documentation
Nov 17, 2022
e520d0f
Update documentation according to suggestions
Nov 17, 2022
e25919a
fix: empty string is considered as undefined
Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-buckets-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/node': minor
---

Allow HOST env variable to be provided at runtime
9 changes: 9 additions & 0 deletions packages/integrations/node/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ node ./dist/server/entry.mjs

For standalone mode the server handles file servering in addition to the page and API routes.


#### Custom host and port

You can override the host and port the standalone server runs on by passing them as environment variables at runtime:

```shell
HOST=0.0.0.0 PORT=3000 node ./dist/server/entry.mjs
```

#### HTTPS

By default the standalone server uses HTTP. This works well if you have a proxy server in front of it that does HTTPS. If you need the standalone server to run HTTPS itself you need to provide your SSL key and certificate.
Expand Down
3 changes: 2 additions & 1 deletion packages/integrations/node/src/standalone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export default function startServer(app: NodeApp, options: Options) {
const { client } = resolvePaths(options);
const handler = middleware(app);

const host = getResolvedHostForHttpServer(options.host);
// Allow to provide host value at runtime
const host = getResolvedHostForHttpServer(process.env.HOST !== undefined && process.env.HOST !== '' ? process.env.HOST : options.host);
const server = createServer(
{
client,
Expand Down