Fix memleak caused by directory names containing '.md' or '.mdx' #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9fe2887 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
VladCuciureanu
changed the title
|
mind adding a test fixture for this? |
| @@ -193,7 +193,7 @@ export default function jsx({ settings, logging }: AstroPluginJSXOptions): Plugi | |||
|
|
|||
| const { mode } = viteConfig; | |||
| // Shortcut: only use Astro renderer for MD and MDX files | |||
| if (id.includes('.mdx') || isMarkdownFile(id, { criteria: 'includes' })) { | |||
| if (id.includes('.mdx') || isMarkdownFile(id, { criteria: 'endsWith' })) { | |||
There was a problem hiding this comment.
If this causes memory leaks for markdown files, maybe it does happen for folders with .mdx too? Would you check that please?
There was a problem hiding this comment.
Oh good point. Gonna fix.
Will do |
VladCuciureanu
changed the title
|
Added test/fixture for this and also fixed what @MoustaphaDev pointed out. |
bluwy
reviewed
Nov 2, 2022
bluwy
approved these changes
Nov 2, 2022
|
Thanks! |
Merged
bholmesdev
pushed a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I must mention, I'm very excited to contribute in some way to this awesome project.
Now, the matter at hand:
This fixes a bug caused by wrongly treating files as markdown. If the project's path contains '.md' (or any markdown extension) serving any page containing javascript results in the server crashing due to the heap running out of memory.
I noticed this behaviour when developing my personal website, 'vladinski.md' :)
Testing
Ran entire test suite.
Writing a test seemed overkill, considering such a peculiar type of bug.
If a test is required, please tell me so and I'll find a way to implement it.
Docs
No docs added since this is a fix that doesn't modify a user's usage.