Allow 200 response for endpoints in build #5258
Conversation
🦋 Changeset detectedLatest commit: 512d5bf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
with the fix in withastro/astro#5258
| throwIfRedirectNotAllowed(result.response, opts.settings.config); | ||
| // If there's no body, do nothing | ||
| if (!result.response.body) return; | ||
| body = await result.response.text(); |
There was a problem hiding this comment.
I think this should be something like body = await result.response.arrayBuffer().then(ab => new Uint8Array(ab)).
Not all response bodies, e.g. images, are valid UTF-8 strings so using Response.text() returns unexpected data during build.
Example: returning new Response(new Uint8Array([0xff])) from a static file endpoint causes Astro (v1.8.0; Node v18.11.0) to generate a file containing <ef bf bd> instead of <ff>.
There was a problem hiding this comment.
Thanks @bmdelacruz! In general it’s safest to create a new issue if you’re seeing buggy behaviour as sometimes older issues and PRs aren’t picked up in the triage process. Would you be able to do that?
Changes
Fix #4930
These changes should make build similar to dev.
Testing
I'm not sure how to test errors that would cause build to fail, but I did test with #4930 to make sure it works.
Docs
Currently the docs doesn't document that they can return a response for static endpoints. I'll document this separately but I don't think it blocks this PR.
withastro/docs#1961