Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Astro.cookies.set types to receive boolean and numbers #5047

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Test added for booleans since there wasn't one.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: d8efa67

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Oct 10, 2022
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matthewp matthewp merged commit 1e27992 into main Oct 12, 2022
@matthewp matthewp deleted the deno-cookies branch October 12, 2022 12:31
@astrobot-houston astrobot-houston mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astrojs : Astro.cookies : set method not working with SSR Deno
4 participants