Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow class to be passed into Svelte islands #5045

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Allow class to be passed into Svelte islands #5045

merged 2 commits into from
Oct 10, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Tested in the examples

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: 07b1794

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Oct 10, 2022
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matthewp matthewp merged commit 0f2a88b into main Oct 10, 2022
@matthewp matthewp deleted the svelte-no-class branch October 10, 2022 19:19
@astrobot-houston astrobot-houston mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/svelte] passing class to island component behaves differently from passing to static component
2 participants