Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vite 3.1 #4752

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Support Vite 3.1 #4752

merged 4 commits into from
Sep 14, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 14, 2022

Changes

While checking out #4727, I noticed that we're incorrectly accessing the this context in the handleHotUpdate hook. This was previously the Vite plugin object, but was removed with the object hooks feature: vitejs/vite#9634 and vitejs/vite#9885

Testing

Tested locally. This issue can be triggered when updating an Astro file. Ideally #4454 should cover this.

Docs

N/A. internal change.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: 60a1a59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 14, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not go ahead and upgrade to 3.1 here too?

@bluwy
Copy link
Member Author

bluwy commented Sep 14, 2022

do we still want to pin it to 3.1 or ~3.1? (or could decide later and pin for now)

@matthewp
Copy link
Contributor

Let's try ~3.1

@bluwy
Copy link
Member Author

bluwy commented Sep 14, 2022

Updated to ~3.1.0 👍

@bluwy
Copy link
Member Author

bluwy commented Sep 14, 2022

Looks like the new Vite types are messing with the Astro build. I reverted the Vite version bump at the meantime and we can probably tackle the types stuff in another PR.

@matthewp matthewp merged commit 1bedb94 into main Sep 14, 2022
@matthewp matthewp deleted the support-vite-3.1 branch September 14, 2022 16:01
@astrobot-houston astrobot-houston mentioned this pull request Sep 14, 2022
matthewp pushed a commit that referenced this pull request Sep 14, 2022
* Support Vite 3.1

* Update ~3.1.0

* Revert Vite bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants