Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console.error filtering #4748

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix console.error filtering #4748

merged 1 commit into from
Sep 14, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 14, 2022

Changes

Fix #4459

The filteredConsoleError hook that patches console.error forgots to call the original console.error if is not filtered out.

Testing

N/A. I think this is a simple fix 😬

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: 11a88e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 14, 2022
@bluwy bluwy merged commit c5e134d into main Sep 14, 2022
@bluwy bluwy deleted the fix-error-filter branch September 14, 2022 14:08
@astrobot-houston astrobot-houston mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs if imported mdx component references component that does not exist
2 participants