Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vue script setup with other renderers applied #4706

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Resolves Vue <script setup> not working #4319
  • Add __ssrInline to Vue component check. Seems Vue components have a different signature with using script setup during production builds

Testing

Add test build with Vue + another integration (Svelte in this example)

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

🦋 Changeset detected

Latest commit: b8eda53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/vue Patch
@e2e/errors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Sep 9, 2022
@bholmesdev bholmesdev merged commit b0ee81d into main Sep 9, 2022
@bholmesdev bholmesdev deleted the fix/vue-render-with-setup-script branch September 9, 2022 23:10
@astrobot-houston astrobot-houston mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue <script setup> not working
2 participants