-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs for long-running integration hooks #4445
Conversation
🦋 Changeset detectedLatest commit: 7b2f333 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -11,13 +12,35 @@ import type { SerializedSSRManifest } from '../core/app/types'; | |||
import type { PageBuildData } from '../core/build/types'; | |||
import { mergeConfig } from '../core/config.js'; | |||
import type { ViteConfigWithSSR } from '../core/create-vite.js'; | |||
import { info, LogOptions } from '../core/logger/core.js'; | |||
|
|||
async function withTakingALongTimeMsg<T>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great function name :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 Played with some short names and thought... why not name it what it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
Waiting for [X] integration...
log across all integration build hooks. This will be triggered for any hook that takes over 3 seconds to resolve. Open to tweaking this timing hook-by-hook if anyone has opinions!Testing
N/A
Docs
N/A