New handling for define:vars scripts and styles
#3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c419857 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
force-pushed
the
fix/define-vars
branch
from
02b15ed
to
b46c016
Compare
⚖️ Bundle Size CheckLatest commit: 77b7e9c
|
This was referenced Jul 21, 2022
Closed
natemoo-re
force-pushed
the
fix/define-vars
branch
from
f8ea331
to
7174f8f
Compare
matthewp
reviewed
Jul 21, 2022
tony-sull
approved these changes
Jul 22, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
define:varshandling for scripts and stylesdefine:varscompiler#470define:vars, we now wrap them in a unique scope with{}to avoid redeclaration errorsscriptbut this was deemed out of scope. We may revisit this in the future.define:vars, we can now ignore them entirely. They are handled at the compiler level.Testing
Tests updated
Docs
Bug fix only