Feat/image url hash #3965
Merged
Feat/image url hash #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54efa1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
JuanM04
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Nice!
Since we've used shorthash twice now, I've extracted it into its own package: littlehash. Feel free to use it if you want
FredKSchott
approved these changes
Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the image component to include a hash of the full image URL when building remote images for SSG
Why?
This address an issue raised in Discord - the user included an
<Image />component for two different images that had the same filename but a different absolute URL (/a/1-0.jpgvs/b/1-0.jpg). The integration was only using a remote image's filename so only the last image was being built.Testing
SSG build tests updated to make sure the hash is included
Docs
None, bug fix only