Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor integrations to language integrations #3864

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jul 8, 2022

Changes

Bit of a tentative PR. It moves the functions needed for the editor integration inside the integrations themselves instead of being in the language server. This will be followed by a PR in the language server to dynamically load that module

The reasoning for doing this is that it'll massively reduce the dependencies of the language server, which should make it much smaller (which is very desirable for astro check)

Testing

I am not too sure how to test this here, the language server CI does test it however

Docs

N/A

@Princesseuh Princesseuh self-assigned this Jul 8, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: 66ab23b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@astrojs/svelte Patch
@astrojs/vue Patch
@e2e/svelte-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Jul 8, 2022
@Princesseuh Princesseuh changed the title [WIP] Add editor integration to language integrations Add editor integrations to language integrations Jul 8, 2022
@Princesseuh Princesseuh marked this pull request as ready for review July 8, 2022 17:41
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Are you going to hard-code these packages with ./editor files into the language server? Or would it make sense to add an editorEntrypoint to the manifest in src/index.ts?

@Princesseuh
Copy link
Member Author

This looks great! Are you going to hard-code these packages with ./editor files into the language server? Or would it make sense to add an editorEntrypoint to the manifest in src/index.ts?

I would've loved to! But it would require the manifest to also be CJS I think? I figured I'd limit my CJS-corruption to a single file 😓

@natemoo-re
Copy link
Member

Ah, I totally see what you mean @Princesseuh! Disregard. 👍🏻

@Princesseuh Princesseuh merged commit f9ed77b into main Jul 8, 2022
@Princesseuh Princesseuh deleted the editor-support-in-integrations branch July 8, 2022 21:47
@astrobot-houston astrobot-houston mentioned this pull request Jul 8, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants