Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing Image component from @astrojs/image #3848

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 7, 2022

Changes

  • Makes it so you can do import { Image } from '@astrojs/image';
  • Adds a export map condition astro that is used to specify a root for Vite.

Testing

  • Tests updated.

Docs

  • Updated the readme for astro/image.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

🦋 Changeset detected

Latest commit: c53ec16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
astro Patch
@astrojs/image Patch
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jul 7, 2022
@FredKSchott
Copy link
Member

LGTM! @Princesseuh brought up one TS concern with this pattern that TS types will need to be manually constructed to include both. Luckily this package already has a custom src/types.ts, so you'd just need to add a export type Image = ... item to it.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! Looks good.

@matthewp matthewp merged commit 502f063 into main Jul 7, 2022
@matthewp matthewp deleted the top-level-exports-integrations branch July 7, 2022 17:49
@astrobot-houston astrobot-houston mentioned this pull request Jul 7, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Allow importing Image component from @astrojs/image

* Adds a changeset

* Export the Image type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants