-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: reintroduce smoke tests across example projects #3669
Changes from all commits
791a17f
b3e6778
758365c
fd2d14f
9de2dd9
44eb5c1
e772a39
2d53751
1aa9041
c576afc
7d466d7
8b96023
4cf383f
35f1271
e8f630a
02e0e1d
ee6671e
9529b1a
a7d035b
568aa72
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'astro': patch | ||
'@astrojs/markdown-remark': patch | ||
--- | ||
|
||
Tooling: reintroduce smoke test across example projects |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,4 +14,4 @@ Written by: {new Intl.ListFormat('en').format(authors.map(d => d.name))}. | |
|
||
Published on: {new Intl.DateTimeFormat('en', {dateStyle: 'long'}).format(published)}. | ||
|
||
<Counter client:idle>## This is a counter!</Counter> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove |
||
<Counter>## This is a counter!</Counter> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,12 +161,17 @@ export default function markdown({ config }: AstroPluginOptions): Plugin { | |
const { layout = '', components = '', setup = '', ...content } = frontmatter; | ||
content.astro = metadata; | ||
const prelude = `--- | ||
import { slug as $$slug } from '@astrojs/markdown-remark/ssr-utils'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove direct import from |
||
import Slugger from 'github-slugger'; | ||
${layout ? `import Layout from '${layout}';` : ''} | ||
${components ? `import * from '${components}';` : ''} | ||
${hasInjectedScript ? `import '${PAGE_SSR_SCRIPT_ID}';` : ''} | ||
${setup} | ||
|
||
const slugger = new Slugger(); | ||
function $$slug(value) { | ||
return slugger.slug(value); | ||
} | ||
|
||
const $$content = ${JSON.stringify(content)} | ||
---`; | ||
const imports = `${layout ? `import Layout from '${layout}';` : ''} | ||
|
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests are mysteriously failing on
windows-latest
. We'll need to investigate separately