Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of dynamic imports / Astro.glob with Deno Deploy #3532

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jun 6, 2022

Changes

Testing

  • Most of the time on this issue was spent getting a test built. Created a new test specifically for this which uses a subcommand to run the test without --allow-read. Some of the other tests do depend on that feature, which is why they aren't all run together.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: 3e97151

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/deno Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 6, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a tricky one to fix since it's so specific to Deno Deploy, great fix!

@matthewp matthewp merged commit c22a07d into main Jun 6, 2022
@matthewp matthewp deleted the fix-deno-deploy branch June 6, 2022 16:02
@github-actions github-actions bot mentioned this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: deploying to netlify edge functions results in error
2 participants