Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: markdown imports failing #3444

Merged
merged 6 commits into from
May 26, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented May 25, 2022

Changes

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

🦋 Changeset detected

Latest commit: ec01502

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/markdown-remark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels May 25, 2022
@github-actions github-actions bot removed pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels May 26, 2022
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 26, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass!

@bholmesdev bholmesdev merged commit 51db2b9 into main May 26, 2022
@bholmesdev bholmesdev deleted the fix/markdown-imports-exploding branch May 26, 2022 00:47
@github-actions github-actions bot mentioned this pull request May 26, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: revert JSX expression hack (temporary!)

* chore: changeset

* fix: skip stray JSX expression test

* Revert "fix: skip stray JSX expression test"

This reverts commit fd3042d.

* Revert "fix: revert JSX expression hack (temporary!)"

This reverts commit b78883f.

* fix: add markdown-remark to external deps!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: markdown imports fail
2 participants