-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ssr url search params bug #3066
Conversation
🦋 Changeset detectedLatest commit: cc7471e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3453d84
to
54e7160
Compare
54e7160
to
cc7471e
Compare
@@ -49,7 +49,6 @@ function printAstroHelp() { | |||
['--config <path>', 'Specify the path to the Astro config file.'], | |||
['--root <path>', 'Specify the path to the project root folder.'], | |||
['--legacy-build', 'Use the build strategy prior to 0.24.0'], | |||
['--experimental-ssr', 'Enable SSR compilation fot 3rd-party adapters.'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, it seems that some unwanted changes got leaked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional! I believe we agreed in a separate convo that experimental
flags should not be documented in the CLI output, since you should only need to worry/know about them when Astro is complaining about it to you directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, I didn't know about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! I should have added a comment here for reviewers
Self-merging as steward since core team is out today, and this is small. |
Changes
Testing
Docs