Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add injected scripts to markdown pages #2848

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

FredKSchott
Copy link
Member

Changes

From LukeWilson in Discord:

Hey everybody, testing out the the new tailwind integration in astro@next here, running into a problem. It works great for pages/index.astro, but for a pages/test.md, the base.css is not injected.

  • Fixes that bug, and cleans up a few small edge cases where the Markdown and Astro page differ to bring Markdown back in line with Astro.

Testing

  • Not covered by existing tests. Realizing that while integrations are covered by test suite, the specific hooks aren't really covered. I'll try to get to that by the end of the day but feel free to review this before then.

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2022

🦋 Changeset detected

Latest commit: b768fb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 21, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FredKSchott FredKSchott merged commit 981e2a8 into main Mar 21, 2022
@FredKSchott FredKSchott deleted the add-scripts-to-markdown-pages branch March 21, 2022 20:05
This was referenced Mar 21, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* add injected scripts to markdown pages

* Create twenty-kiwis-tease.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants