404 page #2719

matthewp · 2022-03-04T16:43:11Z

Changes

Makes it so that the static build writes out to 404.html instead of 404/index.html

Testing

Test added

Docs

Bug fix, N/A

changeset-bot · 2022-03-04T16:43:14Z

🦋 Changeset detected

Latest commit: ad839ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tony-sull

lgtm 👍

natemoo-re

Would love to see all the status codes handled as I think that was a bug we fixed in the past.

packages/astro/src/core/build/static-build.ts

natemoo-re · 2022-03-04T17:28:27Z

Ah looks like the changes from #2525 also got dropped from the sitemap logic in the static build.

astro/packages/astro/src/core/render/sitemap.ts

Line 1 in f848482

const STATUS_CODE_PAGE_REGEXP = /\/[0-9]{3}\/?$/;

* Fix: build to 404.html in the static build * Adds a changeset

* Unflag the static build (#2652) * Unflag the static build * Only set legacyBuild to false if experimentalSSR is true * Use legacy build when we have to * Put a few more tests into legacy mode * Last two * Make astro-basic use the legacy build * Adds a changeset * Mark the lit test as legacy * Update yarn lock * Update based on feedback * Add --legacy-build flag * Move astro-basic test to use static build (#2682) * Move some tests over to the static build (#2677) * Move some tests over to the static build * Fix assets tests * Fix the assets tests * Fix for the client:only components * Moves asset tests to the static build * Move postcss test over to static build * Bring back legacy build for astro-basic test * Move astro-basic test to use static build * Migrate more tests to the static build (#2693) * fix: disable HMR during build (#2684) * Migrate more tests to the static build * Only prepend links in non-legacy mode * Add the 0-css tests * Convert all CSS tests to the static build * Migrate Astro global tests * Remove .only * Fix static build tests * Migrate a few more * More tests * Move the lit test back to legacy * Increase the test timeout Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * Improve `head` injection behavior (#2436) * feat: add renderHead util to server * feat: remove `layouts` from config, Vite plugin * fix: improve head injection during rendering * chore: update compiler * fix: do not escape links * chore: enter `pre` mode * Replace `send` with `sirv` (#2713) * remove send * Create thick-ravens-chew.md * I feel like I'm going to screw something up * working finally! * rewrite req.url * Add tiny bit of doc * Update .gitignore Co-authored-by: Evan Boehs <evan@boehs.org> * Move remaining tests to the static build (#2712) * Move lit test to the static build * Migrate astro-env plugin to work in the static build * Do not remove vite:define * Adds a changeset * Add a warning when passing the --experimental-static-build flag (#2718) * Add a warning when passing the --experimental-static-build flag * Disable the lint warning * [ci] release (next) (#2721) * [ci] release (next) * chore: update changeset Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <nate@skypack.dev> * 404 page (#2719) * Fix: build to 404.html in the static build * Adds a changeset * fix pnpm install missing peer deps * fix svelte version in workspace * fix lockfile * fix(webapi): add dev script * improve preview reliability (#2739) * improve preview reliability - fix broken tests * shamefully hoist to unblock * remove lit from test running * chore: update lockfile Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Evan Boehs <evan@boehs.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com>

* Unflag the static build (withastro#2652) * Unflag the static build * Only set legacyBuild to false if experimentalSSR is true * Use legacy build when we have to * Put a few more tests into legacy mode * Last two * Make astro-basic use the legacy build * Adds a changeset * Mark the lit test as legacy * Update yarn lock * Update based on feedback * Add --legacy-build flag * Move astro-basic test to use static build (withastro#2682) * Move some tests over to the static build (withastro#2677) * Move some tests over to the static build * Fix assets tests * Fix the assets tests * Fix for the client:only components * Moves asset tests to the static build * Move postcss test over to static build * Bring back legacy build for astro-basic test * Move astro-basic test to use static build * Migrate more tests to the static build (withastro#2693) * fix: disable HMR during build (withastro#2684) * Migrate more tests to the static build * Only prepend links in non-legacy mode * Add the 0-css tests * Convert all CSS tests to the static build * Migrate Astro global tests * Remove .only * Fix static build tests * Migrate a few more * More tests * Move the lit test back to legacy * Increase the test timeout Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * Improve `head` injection behavior (withastro#2436) * feat: add renderHead util to server * feat: remove `layouts` from config, Vite plugin * fix: improve head injection during rendering * chore: update compiler * fix: do not escape links * chore: enter `pre` mode * Replace `send` with `sirv` (withastro#2713) * remove send * Create thick-ravens-chew.md * I feel like I'm going to screw something up * working finally! * rewrite req.url * Add tiny bit of doc * Update .gitignore Co-authored-by: Evan Boehs <evan@boehs.org> * Move remaining tests to the static build (withastro#2712) * Move lit test to the static build * Migrate astro-env plugin to work in the static build * Do not remove vite:define * Adds a changeset * Add a warning when passing the --experimental-static-build flag (withastro#2718) * Add a warning when passing the --experimental-static-build flag * Disable the lint warning * [ci] release (next) (withastro#2721) * [ci] release (next) * chore: update changeset Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <nate@skypack.dev> * 404 page (withastro#2719) * Fix: build to 404.html in the static build * Adds a changeset * fix pnpm install missing peer deps * fix svelte version in workspace * fix lockfile * fix(webapi): add dev script * improve preview reliability (withastro#2739) * improve preview reliability - fix broken tests * shamefully hoist to unblock * remove lit from test running * chore: update lockfile Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Evan Boehs <evan@boehs.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Fred K. Schott <fkschott@gmail.com>

github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Mar 4, 2022

matthewp changed the base branch from main to next March 4, 2022 16:43

tony-sull approved these changes Mar 4, 2022

View reviewed changes

natemoo-re reviewed Mar 4, 2022

View reviewed changes

packages/astro/src/core/build/static-build.ts Show resolved Hide resolved

natemoo-re force-pushed the next branch 2 times, most recently from 809f6e7 to 7849150 Compare March 4, 2022 21:27

natemoo-re approved these changes Mar 4, 2022

View reviewed changes

natemoo-re force-pushed the next branch from 7849150 to 04558ea Compare March 4, 2022 21:45

matthewp force-pushed the 404-page branch from 873a5bd to 3b520a6 Compare March 4, 2022 22:00

natemoo-re force-pushed the next branch from 4f143c9 to a68d6a3 Compare March 4, 2022 22:41

matthewp added 2 commits March 7, 2022 09:07

Fix: build to 404.html in the static build

3918c7d

Adds a changeset

ad839ca

matthewp force-pushed the 404-page branch from 3b520a6 to ad839ca Compare March 7, 2022 14:07

matthewp merged commit 049ab7d into next Mar 7, 2022

matthewp deleted the 404-page branch March 7, 2022 14:49

natemoo-re pushed a commit that referenced this pull request Mar 8, 2022

404 page (#2719)

dbdd3f5

* Fix: build to 404.html in the static build * Adds a changeset

natemoo-re pushed a commit that referenced this pull request Mar 9, 2022

404 page (#2719)

7fe4af4

* Fix: build to 404.html in the static build * Adds a changeset

natemoo-re pushed a commit that referenced this pull request Mar 9, 2022

404 page (#2719)

1b38cc3

* Fix: build to 404.html in the static build * Adds a changeset

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

404 page #2719

404 page #2719

matthewp commented Mar 4, 2022

changeset-bot bot commented Mar 4, 2022 •

edited

Loading

tony-sull left a comment

natemoo-re left a comment

natemoo-re commented Mar 4, 2022

404 page #2719

404 page #2719

Conversation

matthewp commented Mar 4, 2022

Changes

Testing

Docs

changeset-bot bot commented Mar 4, 2022 • edited Loading

🦋 Changeset detected

tony-sull left a comment

Choose a reason for hiding this comment

natemoo-re left a comment

Choose a reason for hiding this comment

natemoo-re commented Mar 4, 2022

changeset-bot bot commented Mar 4, 2022 •

edited

Loading