-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changed data-astro-raw
to is:raw
#2706
Conversation
🦋 Changeset detectedLatest commit: 80ff42c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
That's weird. The tests pass but the process exits with a non-zero. What can that |
I'm not sure! Maybe something to do with the Lit tests specifically... |
I say we remove that test and rely on the lit smoke tests to cover lit support. That test has caused us a lot of pain. I'll open a separate PR. |
These lines from the lit test are causing issues: after(async () => {
// The Lit renderer adds browser globals that interfere with other tests, so remove them now.
const globals = Object.keys(globalThis.window || {});
globals.splice(globals.indexOf('global'), 1);
for (let name of globals) {
delete globalThis[name];
}
}); |
Found the culprit: lit/lit#2510 |
@JuanM04 does that PR fix the issue or cause it? |
That PR fixes the previous issues (causing our botch to break). I'll write my findings in your PR |
This can be rebased with main now. Thanks for figuring this out @JuanM04 ! |
* chore: changed `data-astro-raw` to `is:raw` * changesets
Changes
Following the roadmap
Testing
Docs