Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: curly braces inside Shiki #2545

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: curly braces inside Shiki #2545

merged 1 commit into from
Feb 8, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Feb 7, 2022

Changes

Adds data-astro-raw to prevent Astro to think the curly braces inside codeblocks are expression

Testing

n/a

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2022

⚠️ No Changeset found

Latest commit: 5229ee3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels Feb 7, 2022
jonathantneal
jonathantneal approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround, @JuanM04.

@jonathantneal jonathantneal merged commit f0952a8 into withastro:main Feb 8, 2022
@JuanM04 JuanM04 deleted the fix-shiki-curly-brace branch February 8, 2022 11:17
@JuanM04 JuanM04 mentioned this pull request Feb 9, 2022
Merged
jonathantneal pushed a commit that referenced this pull request Feb 10, 2022
@JuanM04
Fixed curly braces inside Shiki codeblocks (#2545) (#2564)
d71c462
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@JuanM04
fix: curly braces inside Shiki (withastro#2545)
04cdebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuanM04 @jonathantneal