Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete robots.txt #2540

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Delete robots.txt #2540

merged 3 commits into from
Feb 7, 2022

Conversation

MarcusOtter
Copy link
Member

Changes

Removes robots.txt from the starter example. Disallow: / is not a great default value, and the file doesn't serve much purpose.
From @Princesseuh:

Hmm, I feel like the file just shouldn't be there. There's already a favicon.ico that shows how the folder work in addition of actually being useful, whereas the robots.txt effectively isn't useful to the starter

The file has also been removed from other examples (for example, minimal).

Testing

No testing

Docs

No docs update required

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2022

⚠️ No Changeset found

Latest commit: 997b04d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Feb 5, 2022
@natemoo-re
Copy link
Member

I think I’m on board with this change, unless there’s a good reason to swap it with a better default robots.txt file.

Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this seems like a good improvement. Thank you, @MarcusOtter!

@jonathantneal jonathantneal merged commit 0caf916 into withastro:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants