Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix define:vars in the static build flag #2511

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Fix define:vars in the static build flag #2511

merged 3 commits into from
Jan 31, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Updates the compiler to the newest version.
  • Allows styles to be added behind the flag, which allows the define:vars styles to be added.

Testing

Added via the example.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f3c8241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) labels Jan 31, 2022
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: d895451

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f857d2eefd57000767d804

😎 Browse the preview: https://deploy-preview-2511--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: f3c8241

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f858b2e9794d00084116a5

😎 Browse the preview: https://deploy-preview-2511--astro-docs-2.netlify.app

@matthewp
Copy link
Contributor Author

Closes #2505

@matthewp matthewp merged commit 3d2c184 into main Jan 31, 2022
@matthewp matthewp deleted the static-build-define-vars branch January 31, 2022 21:56
@matthewp matthewp mentioned this pull request Jan 31, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Merged
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Fix define:vars in the static build flag (withastro#2511)
02dd4b6 
* Fix define:vars in the static build flag

* Adds a changeset

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @jonathantneal