feat(partytown): allow overriding copyLibFiles.dest in astro:build:done hook with the lib option
#13109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d5e936 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
arnottferels
force-pushed
the
feat-astro-partytown
branch
from
a27bb66 to
133f9e4
Compare
…b option, defaulting to ~partytown. Remove leading '/' to match ileURLToPath.
arnottferels
force-pushed
the
feat-astro-partytown
branch
from
133f9e4 to
1d5e936
Compare
|
I'm not familiar with partytown, why would you want something in a different location? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds customization for the default
~partytowncopy file folder in@astrojs/partytownduring theastro:build:donehook.Changes
copyLibFiles.destin theastro:build:donehook using theliboption inastro.config.*.libis not specified, it defaults to~partytown.libvalue to match the behavior offileURLToPath.Testing
If no tests added, explain why.
I didn't add tests because I'm still figuring out how testing works. But I tested it locally by running
astro build, and the copy file from Partytown is being copied correctly. The logic seems to work well.Docs
/cc @withastro/maintainers-docs for feedback!