fix(middleware): compute client address #12222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a2ae1f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Oct 14, 2024
| } | ||
| throw new AstroError(AstroErrorData.StaticClientAddressNotAvailable); | ||
| clientIpAddress = getClientIpAddress(request); |
There was a problem hiding this comment.
I assume this is done here so that we don't need to update each adapter to provide it?
matthewp
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Should be able to add a test for this. I think this one would be the place: https://github.com/withastro/astro/blob/main/packages/astro/test/client-address.test.js
|
@matthewp the bug is around edge middleware specifically, we don't have those tests in core, I think |
|
@matthewp added a unit test |
matthewp
approved these changes
Oct 14, 2024
bluwy
approved these changes
Oct 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12215
Closes PLT-2587
Testing
Added a unit test.
Existing CI should pass
Docs
N/A