fix: 404 and 500 route matching

[braden-w]

Changes

Standardize 404 and 500 route matching via isRoute404 and isRoute500 functions.

Closes #11595

I'm unsure where are the best places to put the isRoute404 and isRoute500 functions, so I put them in packages/astro/src/core/util.ts for now with other util files

They could be moved!

They are used in packages/astro/src/i18n/index.ts and packages/astro/src/vite-plugin-astro-server/route.ts

Testing

No tests were added as no new behavior was added. Ran pnpm test on the astro package via pnpm --filter astro run test.

Docs

n/a, this is a fix in behavior that addresses #11595

[changeset-bot]

🦋 Changeset detected

Latest commit: d7a83a8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ematipico]

@braden-w can you look at the tests? They are failing

[braden-w]

Hmm unsure how to proceed, the errors seem a bit cryptic and unrelated to my changes. Is there anyone who might be well-suited for some guidance on how to read these?

[ematipico]

The issue is that you imported utils.js inside files that can't have node.js modules, and utils.js import node:fs.

I suggest moving those functions inside routing.ts

[parkm]

@braden-w Are you able to implement @ematipico's suggestion?

[codspeed-hq]

CodSpeed Performance Report

Merging #12182 will not alter performance

_{Comparing braden-w:fix/404-and-500-route-matching (d7a83a8) with main (35d77b4)}

Summary

✅ 6 untouched benchmarks