-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new <Code> component, to succeed <Prism> #1208
Conversation
🦋 Changeset detectedLatest commit: 2f0c73c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). astro-www – ./www🔍 Inspect: https://vercel.com/pikapkg/astro-www/ELGi2hZ3W19nd1b9Vb4jYLvrt7tX astro-docs – ./docs🔍 Inspect: https://vercel.com/pikapkg/astro-docs/6n452e1sTKAHGSuQ4TaMKaDpVQQy |
acb88f1
to
914c026
Compare
914c026
to
c526618
Compare
c526618
to
3bc9095
Compare
Could you add a link to the Shiki docs, especially the dark theme docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, otherwise looks pretty great!
I want to get the docs site setup with I think @natemoo-re built a theme for VSCode that we could pull in! |
Just a note that this PR is for the Phase 1 section fo the RFC. |
3bc9095
to
091917b
Compare
091917b
to
13ccf89
Compare
13ccf89
to
e385ba9
Compare
Talked with @matthewp and @natemoo-re today and they convinced me that the Debug change should get pulled out into a separate PR so as not to block the Phase 1 Will remove and ALSO update shiki to latest which will get our tests passing! |
Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz>
Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz>
5fb0422
to
9d3fb9f
Compare
Docs already added, at |
Fixed the code overflow by default problem and added a new
|
043358b
to
2f0c73c
Compare
I forgot to add wanting to show the outputted component w/in the page! both the source & the end result! |
## `<Code />` | ||
|
||
```astro | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be really cool to make use of https://github.com/unlight/remark-sources so that we can provide the rendered version of this code example inline with the component!
* add code component * Update packages/astro/components/Debug.astro Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz> * Update packages/astro/components/Debug.astro Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz> * fix format in debug component * remove Debug changes * add wrap support * add props docs * update default theme Co-authored-by: Peter Singh <drgaud@hotmail.com> Co-authored-by: Caleb Jasik <calebjasik@jasik.xyz>
Changes
<Code>
component, similar to<Prism>
Debug
component to use Code internally, removing the problem of CSS getting added to the page incorrectly! Moves Debug back toimport {Debug} from 'astro/components';
with a nice backwards-compat deprecation message for anyone still using the old import URL.Testing
Docs