feat(markdown): add support for shiki option langAlias
#12039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 421ec4c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
feat: markdown
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
changed the title
langAliasshiki option langAlias
sarah11918
reviewed
Sep 20, 2024
There was a problem hiding this comment.
This looks cool, @ematipico ! I checked out the original feature documentation, and made a suggestion below for your consideration!
bluwy
reviewed
Sep 20, 2024
bluwy
reviewed
Oct 1, 2024
florian-lefebvre
approved these changes
Oct 1, 2024
|
Actually it's our own bug 😅 I went ahead and push a commit to fix it. The idea is to use the aliased lang for |
bluwy
approved these changes
Oct 7, 2024
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
ematipico
force-pushed
the
feat/add-shiki-lang-alias
branch
from
a6a6995 to
b26abe6
Compare
sarah11918
reviewed
Oct 8, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
reviewed
Oct 8, 2024
sarah11918
approved these changes
Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes withastro/roadmap#954
This PR adds support for
langAliasTesting
I added new tests
Docs
withastro/docs#9453