Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assets): Allow customising the route of the image endpoint #11908

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Sep 3, 2024

Changes

Changes the image endpoint config to be a bit more intuitive and allow customizing the route, a niche but sometimes useful usecase. Since this is on the image config, custom endpoints can respect the user's wish regarding where to put it without requiring a special config.

Fix #8847

Testing

Updated tests to use new config

Docs

Some of it is docs! It's autogenerated from config

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: e147e27

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Sep 3, 2024
@bluwy
Copy link
Member

bluwy commented Sep 3, 2024

not using a magic undefined value to mean something

I have a slight preference to use undefined instead if you mean the endpoint.entrypoint property 🤔 You could argue that you're adding a magic "default" value too that technically can be a entrypoint path to a package or alias called default, but we changed that to mean our default value. undefined is more of "let Astro fallback to default handling".

@Princesseuh
Copy link
Member Author

Using undefined is fine with me! I'll change it back.

@github-actions github-actions bot added the semver: major Change triggers a `major` release label Sep 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@Princesseuh Princesseuh merged commit 518433e into next Sep 10, 2024
14 checks passed
@Princesseuh Princesseuh deleted the feat/customize-image-endpoint branch September 10, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants