Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default value of checkOrigin #11788

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Aug 20, 2024

Changes

Closes PLT-2262

It changes the value of security.checkOrigin to true

Testing

I updated the existing tests and removed the config. Tests should still pass

Docs

N/A

/cc @withastro/maintainers-docs for feedback!

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: e1902a0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Aug 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ematipico ! This was one I already had started an entry for in the upgrade guide, so you can also review the entry in the guide here and adjust it as you see fit.

You will also need to update the types/public/config.ts file changing the default in the @docs entry to true. I would also remove the "when enabled" from the start of the sentence and just start with "Performs a check...." since that's now the default behaviour.

That should probably be changed in this PR at the same time. (I think it's fine to keep the version number of the feature at 4.9 though, even though the default value has now changed.)

I like how you showed adding the opt-out, whereas my entry showed removing the 'true' setting as no longer needed. Either one is fine by me, whatever you prefer!

.changeset/itchy-toys-march.md Outdated Show resolved Hide resolved
.changeset/itchy-toys-march.md Outdated Show resolved Hide resolved
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good 👍

@github-actions github-actions bot added pr: docs A PR that includes documentation for review feat: markdown Related to Markdown (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Aug 21, 2024
@ematipico ematipico force-pushed the feat/check-origin-value branch from 9c34209 to 72982b6 Compare August 21, 2024 08:33
@github-actions github-actions bot removed feat: markdown Related to Markdown (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Aug 21, 2024
@ematipico ematipico requested a review from sarah11918 August 21, 2024 08:34
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ematipico ! Approving for docs! 🥳

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ematipico ematipico merged commit 7c0ccfc into next Aug 23, 2024
14 checks passed
@ematipico ematipico deleted the feat/check-origin-value branch August 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants