-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): make astro:env stable #11679
Conversation
🦋 Changeset detectedLatest commit: fbb460e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major
changeset. A reviewer will merge this at the next release if approved.
…astro into feat/unflag-astro-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge once the call for consensus ends and the RFC is merged.
.changeset/eighty-boxes-applaud.md
Outdated
</script> | ||
``` | ||
|
||
If you were previously using this feature, please remove the experimental flag from your Astro config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I rephrase this to say it should just be moved out of the experimental object, not removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's precedent with i18n coming out of experimental! I'll hunt that down!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @florian-lefebvre !
Made some comments below to get this formatted just right.
Also double checking there are no error messages associated with env
? I don't see any here, but if there are, they'd probably need updating too (they might point to the experimental link etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarah11918 some errors there indeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florian-lefebvre just pushed a commit to reorder some of the stuff in the changeset. See what you think, and we can edit as you like!
LGTM! If this looks good to you, I'll merge tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs!
PR approved, merging into next
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
astro:env
stableastro/env/setup
is removed, alongside TLA in adapters. Peer deps are bumped for adaptersTesting
Tests should still pass, manually tested
Docs
Removes a lot of JSDoc since it will move to a proper docs page