Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): make astro:env stable #11679

Merged
merged 27 commits into from
Aug 21, 2024
Merged

feat(next): make astro:env stable #11679

merged 27 commits into from
Aug 21, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Aug 12, 2024

Changes

Testing

Tests should still pass, manually tested

Docs

Removes a lot of JSDoc since it will move to a proper docs page

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: fbb460e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 12, 2024
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Aug 12, 2024
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 12, 2024
@github-actions github-actions bot added the semver: major Change triggers a `major` release label Aug 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre changed the title feat: unflag astro:env feat(next): make astro:env stable Aug 14, 2024
@florian-lefebvre florian-lefebvre marked this pull request as ready for review August 14, 2024 13:13
@florian-lefebvre florian-lefebvre requested a review from bluwy August 15, 2024 12:18
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge once the call for consensus ends and the RFC is merged.

</script>
```

If you were previously using this feature, please remove the experimental flag from your Astro config:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I rephrase this to say it should just be moved out of the experimental object, not removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's precedent with i18n coming out of experimental! I'll hunt that down!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @florian-lefebvre !

Made some comments below to get this formatted just right.

Also double checking there are no error messages associated with env? I don't see any here, but if there are, they'd probably need updating too (they might point to the experimental link etc.)

packages/astro/src/types/public/config.ts Outdated Show resolved Hide resolved
packages/astro/src/types/public/config.ts Outdated Show resolved Hide resolved
packages/astro/src/types/public/config.ts Outdated Show resolved Hide resolved
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 some errors there indeed!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florian-lefebvre just pushed a commit to reorder some of the stuff in the changeset. See what you think, and we can edit as you like!

@florian-lefebvre
Copy link
Member Author

LGTM! If this looks good to you, I'll merge tomorrow

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!

@florian-lefebvre florian-lefebvre dismissed github-actions[bot]’s stale review August 21, 2024 06:37

PR approved, merging into next

@florian-lefebvre florian-lefebvre merged commit ea71b90 into next Aug 21, 2024
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/unflag-astro-env branch August 21, 2024 06:38
ematipico pushed a commit that referenced this pull request Aug 21, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants