Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logging cleanup #11263

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore: logging cleanup #11263

merged 1 commit into from
Jun 17, 2024

Conversation

wackbyte
Copy link
Contributor

Changes

  • Use the logger provided by Astro more consistently in integrations.
  • Remove an old duplicate check in the sitemap integration.

Testing

No tests added because there are no integration log tests (to my knowledge).

Docs

No docs added because this is strictly stylistic.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 453df97

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 14, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset (patch)? You can get one by running pnpm changeset from the root

packages/integrations/sitemap/src/index.ts Show resolved Hide resolved
.changeset/thin-icons-yell.md Outdated Show resolved Hide resolved
Use the logger provided by Astro more consistently in integrations and
remove an old duplicate check in the sitemap integration.
@bluwy bluwy merged commit 7d59750 into withastro:main Jun 17, 2024
12 of 13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 17, 2024
@wackbyte wackbyte deleted the logging-cleanup branch June 17, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants