feat: implement reroute in dev #10818

ematipico · 2024-04-19T11:12:21Z

Changes

Note

This is a series of stacked PRs. This PR targets feat/reroute

This PR implements the rerouting logic in the development environment.

Technical changes:

added the experimental flag experimental.rerouting
The BasePipeline has now two methods:
- tryReroute which accepts the payload coming from a reroute function, and tries to find the RouteData that matches that path, and the component to render
- getComponentInstance, a function that is called to retrieve the module of the component based on its RouteData
The DevPipeline now accepts the ManifestData. In dev this is the real type that contains the up to date information about the current routes. It has also a method to update the ManifestData, which is called every time the dev server updates
The core logic is inside RenderContext. When rerouting occurs, the new reroute function needs to update the RenderContext with new data. Information such as cookies, url, and params depend on the new request.
The RenderContext has new fields:
- isRerouting, used to skip the middleware
- counter, to detect possible loops. If a loop is detected, a 508 is returned

Testing

Just one test for now, but I plan to add more of them

Docs

N/A

changeset-bot · 2024-04-19T11:12:26Z

⚠️ No Changeset found

Latest commit: 7ab1341

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Princesseuh · 2024-04-19T11:13:50Z

packages/astro/src/@types/astro.ts

@@ -245,6 +245,10 @@ export interface AstroGlobal<
 	 * [Astro reference](https://docs.astro.build/en/guides/server-side-rendering/)
 	 */
 	redirect: AstroSharedContext['redirect'];
+	/**
+	 * TODO add documentation


Are all the TODOs here intentional for this PR?

Yes, they are all intentional and I plan to resolve them in a later PR

packages/astro/test/middleware.test.js

* chore: implement reroute in dev * chore: revert naming change * chore: conditionally create the new request * chore: handle error * remove only * remove only * chore: add tests and remove logs * chore: fix regression * chore: fix regression route matching * chore: remove unwanted test

* feat: implement reroute in dev (#10818) * chore: implement reroute in dev * chore: revert naming change * chore: conditionally create the new request * chore: handle error * remove only * remove only * chore: add tests and remove logs * chore: fix regression * chore: fix regression route matching * chore: remove unwanted test * feat: reroute in SSG (#10843) * feat: rerouting in ssg * linting * feat: rerouting in ssg * linting * feat: reroute for SSR * fix rebase * fix merge issue

* feat: implement reroute in dev (#10818) * chore: implement reroute in dev * chore: revert naming change * chore: conditionally create the new request * chore: handle error * remove only * remove only * chore: add tests and remove logs * chore: fix regression * chore: fix regression route matching * chore: remove unwanted test * feat: reroute in SSG (#10843) * feat: rerouting in ssg * linting * feat: rerouting in ssg * linting * feat: reroute for SSR * fix rebase * fix merge issue * feat: implement the `next(payload)` feature for rerouting * chore: revert code * chore: fix code * Apply suggestions from code review Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> --------- Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>