fix(types): manually Pick and Omit from CookieSerializeOptions interface
#10767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad76a00 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
We could but users lose typedocs that way. I don't think maintainability is much of a concern for this part of the codebase, it's very low traffic. |
ematipico
approved these changes
Apr 12, 2024
|
I guess it's superseded by #10776? |
Princesseuh
reviewed
Apr 16, 2024
| CookieSerializeOptions, | ||
| 'domain' | 'path' | 'expires' | 'maxAge' | 'httpOnly' | 'sameSite' | 'secure' | 'encode' | ||
| >; | ||
| // `AstroCookieSetOptions` and `AstroCookieDeleteOptions` are manually copied subsections of `CookieSerializeOptions` because `Omit` and `Pick` result in all fields being required. |
There was a problem hiding this comment.
Any reason it cannot be Partial<Pick...?
There was a problem hiding this comment.
I think it's because jsdoc annotations are lost anyway
|
Closing since it seems like this is not relevant anymore with the PR Florian linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Astro.cookies.setandAstro.cookies.deletewere incorrectly reported as required.Testing
Docs