Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Fixes HTMLAttribute extend to allow everything #10561

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix(types): Fixes HTMLAttribute extend to allow everything #10561

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c295550
fix(types): Fixes HTMLAttribute extend to allow everything
Princesseuh Mar 26, 2024
aa96dcf
nit: add types.d.ts file to the list of file to run astrocheck for
Princesseuh Mar 26, 2024
cab0bff
nit: do it some other way
Princesseuh Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
- "scripts/smoke/check.js"
- "packages/astro/src/@types/astro.ts"
- "pnpm-lock.yaml"
- "packages/astro/types.d.ts"

env:
ASTRO_TELEMETRY_DISABLED: true
Expand Down
3 changes: 2 additions & 1 deletion packages/astro/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export type HTMLAttributes<Tag extends HTMLTag> = Omit<
astroHTML.JSX.IntrinsicElements[Tag],
keyof Omit<AstroBuiltinAttributes, 'class:list'>
> & {
[key: string]: string | number | boolean | null | undefined;
// This is not needed in the actual JSX definitions, because TypeScript implicitly adds it in JSX, however we need it here in case someone is using HTMLAttributes directly
[key: `${string}-${string}`]: any;
};

/**
Expand Down
Loading