fix: ensure outDir doesn't lead to bundlers bloating Lambda size #10550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a13f575 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
|
cc @Princesseuh for a review! |
Princesseuh
approved these changes
Mar 25, 2024
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes withastro/adapters#185, which is a bug around Lambda bundles containing unneeded
distfiles on Netlify. This bug presumably also exists on Vercel, as they use the same tracer under the hood (@vercel/nft).Testing
Added a test to ensure this isn't introduced again to the Vercel integration test suite. I picked that test suite, since we know they also have their own image integration, and that it likely has the same bug as the Netlify adapter.
Docs
It's a bug fix, I don't see a need to change docs.