Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not append trailing slash to subresource urls #10491

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

castarco
Copy link
Contributor

@castarco castarco commented Mar 19, 2024

Changes

Testing

  • Added a new couple of tests to ensure that subresources such as .css files are properly served with a 200 status response.

Docs

This change is a bugfix, no documentation changes are needed.

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 6c6637d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 19, 2024
@castarco castarco marked this pull request as ready for review March 19, 2024 11:36
.changeset/tender-snails-accept.md Outdated Show resolved Hide resolved
packages/integrations/node/src/serve-static.ts Outdated Show resolved Hide resolved
Signed-off-by: Andres Correa Casablanca <andreu@kindspells.dev>
@castarco castarco force-pushed the fix/node-trailing-slash branch from f2fb999 to 0abf851 Compare March 19, 2024 12:10
Signed-off-by: Andres Correa Casablanca <andreu@kindspells.dev>
@castarco castarco force-pushed the fix/node-trailing-slash branch from 87615c9 to 2184d75 Compare March 19, 2024 12:34
@castarco castarco changed the title fix: do not append traling slash to subresource urls fix: do not append trailing slash to subresource urls Mar 19, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for fixing the test as well.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
@lilnasy lilnasy merged commit 28e33a2 into withastro:main Mar 19, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astro preview appends / to stylesheet URLs in some circumstances
3 participants