Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: @astrojs/image webp format does not output animated images when given a GIF #4139

Closed
1 task done
jackmerrill opened this issue Aug 4, 2022 · 0 comments · Fixed by #4140
Closed
1 task done

🐛 BUG: @astrojs/image webp format does not output animated images when given a GIF #4139

jackmerrill opened this issue Aug 4, 2022 · 0 comments · Fixed by #4140

Comments

@jackmerrill
Copy link
Contributor

What version of astro are you using?

v1.0.0-rc.4

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Windows

Describe the Bug

When giving the <Image /> component a GIF with the webp format selected, it does not output an animated WEBP.

This can likely be fixed with this: lovell/sharp#1823 (comment)

(Change line 85 here https://github.com/withastro/astro/blob/main/packages/integrations/image/src/loaders/sharp.ts#L85)

Link to Minimal Reproducible Example

N/A

Participation

  • I am willing to submit a pull request for this issue.
jackmerrill added a commit to jackmerrill/astro that referenced this issue Aug 4, 2022
@jackmerrill
feat(image): Add GIF -> WEBP support (withastro#4139)
90261d6
@jackmerrill jackmerrill mentioned this issue Aug 4, 2022
Merged
natemoo-re added a commit that referenced this issue Aug 5, 2022
@jackmerrill @natemoo-re
feat(image): Add GIF -> WEBP support (#4139) (#4140)
4678a3f 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
AllanChain added a commit to AllanChain/blog that referenced this issue Aug 16, 2022
@AllanChain
fix: pin astro version to 1.0.1
bf98b38 
withastro/astro#4139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(image): Add GIF -> WEBP support (#4139) jackmerrill/astro
1 participant
@jackmerrill