Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Requiring Node ^14.20.0 breaks on CodeSandbox #3936

Closed
1 task done
delucis opened this issue Jul 15, 2022 · 0 comments · Fixed by #3937
Closed
1 task done

🐛 BUG: Requiring Node ^14.20.0 breaks on CodeSandbox #3936

delucis opened this issue Jul 15, 2022 · 0 comments · Fixed by #3937

Comments

@delucis
Copy link
Member

delucis commented Jul 15, 2022

What version of astro are you using?

v1.0.0-beta.72

Are you using an SSR adapter? If so, which one?

n/a

What package manager are you using?

yarn

What operating system are you using?

CodeSandbox (Linux container?)

Describe the Bug

Astro’s engines field in package.json requires Node to be ^14.20.0 || >=16.14.0 but CodeSandbox is currently running on 14.18.1 so trying to use one of the example projects from astro.new results in an error:

error astro@1.0.0-beta.72: The engine "node" is incompatible with this module.
Expected version "^14.20.0 || >=16.14.0". Got "14.18.1"

Same applies if we were to configure our CodeSandbox templates to run Node 16. They currently ship 16.12.0 which also falls outside of our semver range. (Thanks @hippotastic for checking that!)

Are we safe to roll back even further in engines? There are several security patches between 14.18.1 and 14.20.0 (see CHANGELOG), but in this case we’re allowing people to choose to use those, not forcing them to. Paging @ran-dall as he worked on the last rollback.

Interesting side note: CodeSandbox evidently persist their project containers so if you follow a link from astro.new, those projects error with the above message but then successfully start running using beta.65 — presumably because it was previously installed. Once you fork the sandbox there is no existing installation so the whole thing fails.

Link to Minimal Reproducible Example

https://codesandbox.io/s/astro-engines-repro-fjbkvp

Participation

  • I am willing to submit a pull request for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant